Repository navigation
Add error scenarios to dedicated network test definitions - #177
Merged
tlohmar merged 14 commits intoSep 10, 2026
Merged
Conversation
Add Gherkin error scenarios covering the documented 4xx responses for the networks, areas and profiles APIs, asserting both the HTTP status and the $.code value of each documented error. Addresses camaraproject#165 for three of the four APIs. Error scenarios for dedicated-network-accesses.feature follow separately. Co-Authored-By: Jim Feng <jim.feng@ericsson.com>
jimfengjinhua
requested review from
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
September 4, 2026 07:48
tlohmar
reviewed
Sep 7, 2026
tlohmar
reviewed
Sep 7, 2026
tlohmar
reviewed
Sep 7, 2026
tlohmar
reviewed
Sep 7, 2026
tlohmar
reviewed
Sep 7, 2026
tlohmar
reviewed
Sep 7, 2026
tlohmar
previously approved these changes
Sep 7, 2026
tlohmar
left a comment
tlohmar
left a comment
Contributor
There was a problem hiding this comment.
Looks good, also the 422 EC on createNetwork is captured
Brings in the sunny day test definitions merged via PR camaraproject#178 so this branch is up to date with main. No conflicts: the success scenarios added on main and the error scenarios added here touch disjoint regions of the three feature files.
Drops a trailing blank line at the end of both files and a double blank line after the retrieveNetworkServiceAreas error section banner, so the banner spacing matches the networks file. Whitespace only - the non-blank content of both files is unchanged.
tlohmar
approved these changes
Sep 10, 2026
tlohmar
left a comment
tlohmar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating to be against latest main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add error scenarios covering the documented 4xx responses for the networks, areas and profiles APIs, asserting both the HTTP status and the $.code value of each documented error.
Addresses #165 for three of the four APIs. Error scenarios for dedicated-network-accesses.feature follow separately.
Which issue(s) this PR fixes:
Addresses #165 (networks, areas and profiles).
Special notes for reviewers:
dedicated-network-accesses.feature error scenarios will follow in a separate PR,
so this does not fully close #165.
Changelog input
Additional documentation
This section can be blank.