Repository navigation
Address release r2.2 review issues on Networks and Profiles APIs - #174
Merged
tlohmar merged 5 commits intoAug 28, 2026
Conversation
hubertp-ericsson
requested review from
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
August 27, 2026 16:48
tlohmar
reviewed
Aug 28, 2026
tlohmar
reviewed
Aug 28, 2026
tlohmar
reviewed
Aug 28, 2026
Comment on lines
+593
to
+594
| - DEDICATED_NETWORK.NETWORK_PROFILE_IDENTIFIER_NOT_FOUND | ||
| - DEDICATED_NETWORK.SERVICE_AREA_IDENTIFIER_NOT_FOUND |
Contributor
There was a problem hiding this comment.
We also need an DEDICATED_NETWORK.QOS_PROFILE_NAME_NOT_FOUND enum
tlohmar
approved these changes
Aug 28, 2026
tlohmar
left a comment
tlohmar
left a comment
Contributor
There was a problem hiding this comment.
Looks good. All identified issues addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
This PR proposes changes to address the following release r2.2 review issues #156 related to the Networks and the Profiles APIs:
Which issue(s) this PR fixes:
Fixes #157
Fixes #158
Fixes #159
Fixes #160
Fixes #161
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.