Skip to content

Align with Commonalities r4.4 - #61

Open
maheshc01 wants to merge 1 commit into
mainfrom
fix/align-commonalities-r4.4
Open

maheshc01 wants to merge 1 commit into
mainfrom
fix/align-commonalities-r4.4

Conversation

@maheshc01

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • correction

What this PR does / why we need it:

Aligns the API with Commonalities r4.4 for the r2.2 release candidate.

  • 401 and 403 now reference the r4.4 catalogue responses (Unauthenticated401, PermissionDenied403)
  • 400, 404, 422 and 429 stay local since they carry API-specific codes/examples, but now reference the shared r4.4 examples for the standard codes
  • Re-added 422 UNSUPPORTED_IDENTIFIER with the C01.06 test scenario
  • ipv4Addresses / ipv6Addresses items now use the common SingleIpv4Address / SingleIpv6Address
  • Updated the mandatory info.description sections from the r4.4 templates
  • Fixed the review comments from fix: address r2.1 release review findings #51, #52, #53 #54 (single address wording, removed networkAccessIdentifier from the example)

Which issue(s) this PR fixes:

Fixes #49
Fixes #55

Special notes for reviewers:

Next step after merge is the r2.2 snapshot.

Changelog input

 release-note
Aligned with Commonalities r4.4 error responses and templates; re-added 422 UNSUPPORTED_IDENTIFIER; description fixes (#55)

Additional documentation

docs

- Use r4.4 catalogue responses for 401/403, shared examples for the rest
- Re-add UNSUPPORTED_IDENTIFIER (422) and C01.06 test
- Use common SingleIpv4Address/SingleIpv6Address
- Update mandatory description text from r4.4 templates
- Fix ipv4Addresses/ipv6Addresses descriptions and NAI example (#55)
@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

@Kevsy Kevsy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align descriptions and examples with schema constraints (follow-up from #54 review) Align error schema names to Commonalities r4.4

2 participants