[TASK] added Polygon get_self_intersection_lines() function, to find out... - #1
Open
kmcs wants to merge 1 commit into
Open
[TASK] added Polygon get_self_intersection_lines() function, to find out...#1kmcs wants to merge 1 commit into
kmcs wants to merge 1 commit into
Conversation
…out after simple_polygon() test, which lines from the polygon have the self-intersection.
Owner
There was a problem hiding this comment.
there is no need for a getter here, you can just access self_intersection_lines
Owner
|
not sure this is the best way to do it, a different method called is_complex or something that either returns the array or false might be a better idea as it can give ALL the self intersecting lines not just the first that it hits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... after simple_polygon() test, which lines from the polygon have the self-intersection.