New function to correct subject ids #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorrell
reviewed
May 12, 2025
run_subject_id_correction.py
Outdated
|
|
||
| def all_corrected(): | ||
|
|
||
| record = "2d2wf-j0256" |
There was a problem hiding this comment.
I'd like the test to create the test record.
tmorrell
reviewed
May 12, 2025
| return False | ||
| print("All subject ids were added") | ||
| return True | ||
|
|
There was a problem hiding this comment.
Add a test where a record has some subjects that aren't being edited
|
Also add your info to the codemeta.json file, like you did for caltechdata_api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a new function to correct subject ids in caltechdata.