fix: don't ship generated code with the library #819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently have
includesGenerateCode: true
which ships codegen specs with the library. The original idea was that the generated code is consistent regardless of React Native version, which can lead to better stability.However, in a practical sense, a different React Native version may not support this generated code anyway, so the library may get locked to single React Native version anyway.
This has caused issues for us - breaking our template almost every React Native release due to API changes in the codegen script, which adds a maintenance burden without any concrete benefits.
So, this change removes this option from the default template. The documentation has been updated as well with instructions on how to enable this.
Test plan
Generate the Turbo Module and Fabric templates and verify that the app builds and runs on Android & iOS.