refactor: rename upperCaseVariantName to more descriptive capitalizedVariantName
#165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artus9033
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the refactor idea brought up in #163. There are multiple places in code similar to
val upperCaseVariantName = variant.name.replaceFirstChar(Char::titlecase), which are misleading: the transform alters the first char to be uppercase, rest remains the same; the name is therefore misleading since it claims the whole variable would be uppercase. A name I'd suggest iscapitalizedVariantName, since it reflects the naming best in my opinion.Fixes - #164
Test plan
CI green.