Skip to content

feat: support flavors for JSBundle #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrei-zgirvaci merged 7 commits into from
Dec 8, 2025
Merged

feat: support flavors for JSBundle #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b48ea4
feat: support non default variants
andrei-zgirvaci Dec 5, 2025
db610e4
feat: set source assets for only release variants
andrei-zgirvaci Dec 8, 2025
5443bff
fix: if declaration order
andrei-zgirvaci Dec 8, 2025
4567e11
Revert "fix: if declaration order"
andrei-zgirvaci Dec 8, 2025
c7d05c5
Revert "feat: set source assets for only release variants"
andrei-zgirvaci Dec 8, 2025
fa9289b
fix: rebase conflicts
andrei-zgirvaci Dec 8, 2025
4146206
feat: ignore gpg
andrei-zgirvaci Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,4 @@ example/.yarn/*
# generated by bob
lib/

secring.gpg
26 changes: 15 additions & 11 deletions ...ns/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/plugin/RNSourceSets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,22 @@ object RNSourceSets {
}

private fun configureSourceSets() {
androidExtension.sourceSets.getByName("main") { sourceSet ->
for (bundlePathSegment in listOf(
// outputs for RN <= 0.81
"createBundleReleaseJsAndAssets",
// outputs for RN >= 0.82
"react/release",
)) {
sourceSet.assets.srcDirs("$appBuildDir/generated/assets/$bundlePathSegment")
sourceSet.res.srcDirs("$appBuildDir/generated/res/$bundlePathSegment")
project.extensions.getByType(LibraryExtension::class.java).libraryVariants.all { variant ->
val capitalizedVariantName = variant.name.replaceFirstChar(Char::titlecase)

androidExtension.sourceSets.getByName("main") { sourceSet ->
for (bundlePathSegment in listOf(
// outputs for RN <= 0.81
"createBundle${capitalizedVariantName}JsAndAssets",
// outputs for RN >= 0.82
"react/release",
)) {
sourceSet.assets.srcDirs("$appBuildDir/generated/assets/$bundlePathSegment")
sourceSet.res.srcDirs("$appBuildDir/generated/res/$bundlePathSegment")
}

sourceSet.java.srcDirs("$moduleBuildDir/generated/autolinking/src/main/java")
}

sourceSet.java.srcDirs("$moduleBuildDir/generated/autolinking/src/main/java")
}

androidExtension.sourceSets.getByName("release") {
Expand Down
4 changes: 2 additions & 2 deletions .../brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ class VariantProcessor(private val variant: LibraryVariant) : BaseProject() {
throw TaskNotFound("Can not find $preBuildTaskPath task")
}

if (capitalizedVariantName == "Release") {
prepareTask.dependsOn(":app:createBundleReleaseJsAndAssets")
if (capitalizedVariantName.contains("Release")) {
prepareTask.dependsOn(":app:createBundle${capitalizedVariantName}JsAndAssets")
}

val bundleTask = variantTaskProvider.bundleTaskProvider(project, variant.name)
Expand Down
Loading