Skip to content

New role prominent (SDK27+) - #585

Open
retyui wants to merge 1 commit into
mainfrom
sdk27
Open

retyui wants to merge 1 commit into
mainfrom
sdk27

Conversation

@retyui

@retyui retyui commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

PR Description

Add a new role prominent

  1. Only one tab can receive the prominent treatment
  2. Available from SDK27+

How to test?

well...

Screenshots

Screenshot 2026-09-19 at 23 48 33

@retyui
retyui requested a balanced review from Copilot September 19, 2026 22:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@retyui
retyui requested a review from thiagobrez September 20, 2026 19:06
#endif
// `.prominent` role was introduced in iOS 27 SDK; ignore it on older OS versions
// instead of crashing or silently mapping to the wrong role.
return nil

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about fallback value, maybe it's better to return search for old sdk versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants