docs(agents): answer review findings at the owning rule - #2620
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an "Answering review findings" section to
docs/agents/pull-requests.md, and extends the smaller-design bullet so the question is asked when a change adds an abstraction, seam, dependency, or ownership rule, whatever its size.Why: the five open PRs with the most review rounds (#2571, #2600, #2599, #2598, #2592) show the same shape. A finding names sites or half a rule; the fix patches exactly those sites and claims completeness; the next review finds the next site. On #2571 one ask ("one parser for the warnings field") took four rounds although a single grep at the first head showed every remaining copy. The new rules make the implementer fix at what enumerates the sites, carry the grep with any completeness claim, use test doubles that fail the way production fails, and point live evidence at the route the change adds.
The review-side rules stay where they are; this adds no second review checklist. One file touched.
Validation
Docs-only; no runtime behavior changes, so no runtime tests apply. On this commit:
pnpm check:agent-guidancepasses (byte budgets and routing contracts),pnpm format:checkpasses.