Conversation
Member
|
No findings at a745e45. Reporter codes are validated before aggregation and JSON success output, and the CLI regression covers the false-success case. Ready for human review. The remaining iOS smoke failure is an alert-replacement XCTest assertion and appears unrelated to this CLI-only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the reporter exit-code guarantee from #959, characterized in #1505: a custom reporter must not mask a failing suite. On current
main, a reporter returning256or512makes this command exit successfully on Linux even when a test fails:agent-device test ./workflows --reporter ./reporter.mjsValidate
getExitCoderesults as integers from0to255, orundefined, before aggregation and JSON success output. Invalid values fail withINVALID_ARGS; valid reporters retain the highest-code rule and failed-suite floor. Eight files, including regression tests, public type documentation, help, user docs, and changelog.Validation
Tested
a745e45c6aa5d05afdb0e4659608ef6e93c40193using Node 24.13.1, pnpm 11.17.0, andAGENT_DEVICE_VITEST_MAX_WORKERS=1.0,3,255,256, and512. Upstream gives eight incorrect exit statuses.pnpm check:affected --runpasses all runnable checks: 2,805 tests across 383 files, formatting, lint, types, layering, Fallow, and build.No device run: the changed boundary is local CLI reporting. Upstream CI is pending.