test(daemon): split the two replay test files over the size tripwire

[thymikee]

Summary

Follow-up to #2353. No *.test.ts under src/daemon/** should sit over the 1,000-line tripwire, so the size ratchet can fail on new size, not only on growth (#2417 left these two). Split into sibling <base>-<concern>.test.ts files:

• session-replay-divergence.test.ts (1,100) -> suggestions, chrome-filter, overlay, capture-policy, observation — 13 cases.
• session-replay-runtime-maestro.test.ts (1,963) -> dispatch, run-script, targeting, swipe, keyboard, run-flow, shell-artifacts — 43 cases.

Divergence siblings mock inline (Vitest hoists a file's own vi.mock above its own imports, so the SUT loads under them), matching the existing session-replay-divergence-android-occlusion.test.ts sibling. The freshness-retry sleep stub is declared only in the two siblings that exercise a retry branch, so it stays local. Maestro keeps session-replay-runtime-maestro.fixtures.ts (24-line resolveTargetDevice + the runReplayFixture harness): Vitest allows one vi.mock per module per file, so the Maestro family cannot reuse session-replay-runtime.test.ts's differently-resolved device, and copying that mock + harness per file is what #2446 asked to avoid. 17 files touched, test-only.

Isolation tradeoff vs #2446. #2446 asked for a shared divergence fixtures module so a mock can't leak into unrelated siblings. A file's own inline mock cannot leak at all, and the divergence shared setup was only the 6-line dispatch+interactor mock plus a resetLegacySnapshotCapture call that already exists — extracting a fixtures module there forced a frozen-object SUT hand-off and a load-bearing import-order invariant, costing more than the leak risk it prevented. Maestro genuinely needs fixtures for the reasons above, so the two families diverge on purpose.

Validation

Tested at ba061f5 (final revision).

• 56 test cases preserved (13 + 43) under src/daemon/replay/internal/__tests__; test titles and assertion multisets diffed identical vs main.
• pnpm check:affected --run green (vitest-related, layering, mutation-registry, size ratchet — largest new file 605 lines).
• pnpm lint, pnpm typecheck green.
• Test-only change: no runtime/coverage/device behavior touched, so provider/coverage lanes are unaffected.

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	4.53 MB	4.53 MB	-246 B
Package (unpacked)	4.53 MB	4.53 MB	-246 B
Package (download)	1.34 MB	1.34 MB	-136 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	27.6 ms	27.3 ms	-0.3 ms
CLI --help	78.2 ms	77.8 ms	-0.4 ms

[thymikee]

No test-behavior findings at ba061f5: all 56 test bodies are preserved, and the split keeps retry mocks isolated. Please refresh the summary and validation revision: the final diff has 17 files and file-local divergence mocks, not the shared divergence fixtures currently described; explain that isolation tradeoff against #2446. Completed checks are green, with iOS still running.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-10 13:15 UTC

[thymikee]

Refreshed the summary/validation to the final revision (ba061f5, 17 files): divergence siblings now carry file-local mocks (Vitest hoists a file's own vi.mock above its imports) with the retry sleep stub confined to the two retry siblings, and only Maestro keeps a fixtures module. Added an Isolation tradeoff vs #2446 paragraph: inline mocks can't leak, and divergence's shared setup was too small to justify the frozen-object hand-off + import-order invariant the fixtures module required — Maestro keeps fixtures only because the one-mock-per-module rule and shared harness size make them load-bearing.