Reset terminal cursor style after each prompt #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made some changes. Now, instead of being called after every prompt, it's called by using registering a callback with Also, using the cursor reset sequence yielded inconsistent results across terminals. I was confused, because when using vim it seems that the cursor is correctly reset regardless of the shell or terminal. It turns out that when vim exits it just sets the cursor to whatever its normal mode setting is! https://github.com/vim/vim/blob/d392a74c5a8af8271a33a20d37ae1a8ea422cb4b/runtime/doc/term.txt#L737-L738 If it's good enough for vim then it's good enough for us! Thus, these changes set the cursor to "steady block" on exit. |
caleb-allen
deleted the
caleb-allen/return-cursor-to-normal-mode-upon-exiting
branch
caleb-allen
added a commit
that referenced
this pull request
Jul 14, 2023
Set the terminal cursor to block style when the REPL exits by using registering a callback with `atexit` . Fixes #72 and fixes #51. Also, using the cursor reset sequence yielded inconsistent results across terminals. I was confused, because when using vim it seems that the cursor is correctly reset regardless of the shell or terminal. It turns out that when vim exits it just sets the cursor to whatever its normal mode setting is! https://github.com/vim/vim/blob/d392a74c5a8af8271a33a20d37ae1a8ea422cb4b/runtime/doc/term.txt#L737-L738 If it's good enough for vim then it's good enough for us! Thus, these changes set the cursor to "steady block" on exit.
caleb-allen
added a commit
that referenced
this pull request
Jul 20, 2023
Set the terminal cursor to block style when the REPL exits by using registering a callback with `atexit` . Fixes #72 and fixes #51. Also, using the cursor reset sequence yielded inconsistent results across terminals. I was confused, because when using vim it seems that the cursor is correctly reset regardless of the shell or terminal. It turns out that when vim exits it just sets the cursor to whatever its normal mode setting is! https://github.com/vim/vim/blob/d392a74c5a8af8271a33a20d37ae1a8ea422cb4b/runtime/doc/term.txt#L737-L738 If it's good enough for vim then it's good enough for us! Thus, these changes set the cursor to "steady block" on exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #72 and #51. The solution here is to print
VTE_CURSOR_STYLE_TERMINAL_DEFAULT, whose value is"\033[0 q", tostdoutafter each prompt. When entering a new prompt line, this means that a reset sequence is sent, shortly followed by anIBEAMsequence. I had concerns that this would cause unpleasant flashing, but it seems to be fast enough that a block isn't rendered for quick commands. It works well in my testing withxterm,termite,alacritty, and the embedded terminal in vs-code (xtermjsI think?).This does have an odd side-effect that the cursor returns to the default style while a long command is running, for example
sleep(5).In the course of testing this, I discovered that the vs-code terminal does not properly handle the control sequence for resetting the cursor to the default style (
\033[0 q). Instead, it sets it to a blinking block cursor. There is a well-detailed issue documenting this: xtermjs/xterm.js#3293This might justify a new issue for this package. It's certainly annoying—we may be able to have a hacky mitigation detecting if any vs-code related libraries, and setting the cursor to block. Not a great solution though.