-
Notifications
You must be signed in to change notification settings - Fork 15
Updates black to latest version and pre-commit to 6.0.0 #4409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Terraform plan in iac/cal-itp-data-infra/airflow/us Plan: 0 to add, 7 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_storage_bucket_object.calitp-composer["dags/airtable_loader_v2/generate_gtfs_download_configs.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer" {
!~ crc32c = "LLSRKg==" -> (known after apply)
!~ detect_md5hash = "WEFwfVbJm4J6LdTF0abD2A==" -> "different hash"
!~ generation = 1751416672748889 -> (known after apply)
id = "calitp-composer-dags/airtable_loader_v2/generate_gtfs_download_configs.py"
!~ md5hash = "WEFwfVbJm4J6LdTF0abD2A==" -> (known after apply)
name = "dags/airtable_loader_v2/generate_gtfs_download_configs.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer["dags/dags.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer" {
!~ crc32c = "tQl0DA==" -> (known after apply)
!~ detect_md5hash = "B95K3uhC41c6uMX4cvS/GA==" -> "different hash"
!~ generation = 1757464207493746 -> (known after apply)
id = "calitp-composer-dags/dags.py"
!~ md5hash = "B95K3uhC41c6uMX4cvS/GA==" -> (known after apply)
name = "dags/dags.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer["plugins/operators/external_table.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer" {
!~ crc32c = "5tuxKg==" -> (known after apply)
!~ detect_md5hash = "xi/tINiysz98MzBL0mOvFg==" -> "different hash"
!~ generation = 1751416674508548 -> (known after apply)
id = "calitp-composer-plugins/operators/external_table.py"
!~ md5hash = "xi/tINiysz98MzBL0mOvFg==" -> (known after apply)
name = "plugins/operators/external_table.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer["plugins/scripts/gtfs_rt_parser.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer" {
!~ crc32c = "qYETHA==" -> (known after apply)
!~ detect_md5hash = "1sRWG9gMSF57EIUYXiLLHw==" -> "different hash"
!~ generation = 1759360707524627 -> (known after apply)
id = "calitp-composer-plugins/scripts/gtfs_rt_parser.py"
!~ md5hash = "1sRWG9gMSF57EIUYXiLLHw==" -> (known after apply)
name = "plugins/scripts/gtfs_rt_parser.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-catalog will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-catalog" {
!~ content = (sensitive value)
!~ crc32c = "HFLpFA==" -> (known after apply)
!~ detect_md5hash = "AxlvqGlF0XQytL7X6uBrow==" -> "different hash"
!~ generation = 1761674676592506 -> (known after apply)
id = "calitp-composer-data/warehouse/target/catalog.json"
!~ md5hash = "AxlvqGlF0XQytL7X6uBrow==" -> (known after apply)
name = "data/warehouse/target/catalog.json"
# (16 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-dags["seeds/transit_facilities_to_csv.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-dags" {
!~ crc32c = "zjpyeA==" -> (known after apply)
!~ detect_md5hash = "bX1yRaWCcgHbVgiOxpWe7A==" -> "different hash"
!~ generation = 1752188818455782 -> (known after apply)
id = "calitp-composer-data/warehouse/seeds/transit_facilities_to_csv.py"
!~ md5hash = "bX1yRaWCcgHbVgiOxpWe7A==" -> (known after apply)
name = "data/warehouse/seeds/transit_facilities_to_csv.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-manifest will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-manifest" {
!~ content = (sensitive value)
!~ crc32c = "JvfK6A==" -> (known after apply)
!~ detect_md5hash = "/ncG1pOau+Ob3onRgEJBiQ==" -> "different hash"
!~ generation = 1761674678163486 -> (known after apply)
id = "calitp-composer-data/warehouse/target/manifest.json"
!~ md5hash = "/ncG1pOau+Ob3onRgEJBiQ==" -> (known after apply)
name = "data/warehouse/target/manifest.json"
# (16 unchanged attributes hidden)
}
Plan: 0 to add, 7 to change, 0 to destroy.📝 Plan generated in Plan Terraform for Warehouse and DAG changes #887 |
|
Terraform plan in iac/cal-itp-data-infra-staging/airflow/us Plan: 0 to add, 7 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_storage_bucket_object.calitp-staging-composer["dags/airtable_loader_v2/generate_gtfs_download_configs.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer" {
!~ crc32c = "LLSRKg==" -> (known after apply)
!~ detect_md5hash = "WEFwfVbJm4J6LdTF0abD2A==" -> "different hash"
!~ generation = 1749661090914530 -> (known after apply)
id = "calitp-staging-composer-dags/airtable_loader_v2/generate_gtfs_download_configs.py"
!~ md5hash = "WEFwfVbJm4J6LdTF0abD2A==" -> (known after apply)
name = "dags/airtable_loader_v2/generate_gtfs_download_configs.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer["dags/dags.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer" {
!~ crc32c = "tQl0DA==" -> (known after apply)
!~ detect_md5hash = "B95K3uhC41c6uMX4cvS/GA==" -> "different hash"
!~ generation = 1757464205425677 -> (known after apply)
id = "calitp-staging-composer-dags/dags.py"
!~ md5hash = "B95K3uhC41c6uMX4cvS/GA==" -> (known after apply)
name = "dags/dags.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer["plugins/operators/external_table.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer" {
!~ crc32c = "5tuxKg==" -> (known after apply)
!~ detect_md5hash = "xi/tINiysz98MzBL0mOvFg==" -> "different hash"
!~ generation = 1749661092552211 -> (known after apply)
id = "calitp-staging-composer-plugins/operators/external_table.py"
!~ md5hash = "xi/tINiysz98MzBL0mOvFg==" -> (known after apply)
name = "plugins/operators/external_table.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer["plugins/scripts/gtfs_rt_parser.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer" {
!~ crc32c = "qYETHA==" -> (known after apply)
!~ detect_md5hash = "1sRWG9gMSF57EIUYXiLLHw==" -> "different hash"
!~ generation = 1759360739479217 -> (known after apply)
id = "calitp-staging-composer-plugins/scripts/gtfs_rt_parser.py"
!~ md5hash = "1sRWG9gMSF57EIUYXiLLHw==" -> (known after apply)
name = "plugins/scripts/gtfs_rt_parser.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-catalog will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-catalog" {
!~ content = (sensitive value)
!~ crc32c = "1i8UoQ==" -> (known after apply)
!~ detect_md5hash = "AuPW9LguwJy2KREUq9TDuQ==" -> "different hash"
!~ generation = 1761707840567648 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/target/catalog.json"
!~ md5hash = "AuPW9LguwJy2KREUq9TDuQ==" -> (known after apply)
name = "data/warehouse/target/catalog.json"
# (16 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-dags["seeds/transit_facilities_to_csv.py"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-dags" {
!~ crc32c = "zjpyeA==" -> (known after apply)
!~ detect_md5hash = "bX1yRaWCcgHbVgiOxpWe7A==" -> "different hash"
!~ generation = 1752188817224893 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/seeds/transit_facilities_to_csv.py"
!~ md5hash = "bX1yRaWCcgHbVgiOxpWe7A==" -> (known after apply)
name = "data/warehouse/seeds/transit_facilities_to_csv.py"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-manifest will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-manifest" {
!~ content = (sensitive value)
!~ crc32c = "ssWdTA==" -> (known after apply)
!~ detect_md5hash = "w/s8aO2JrjlY5X2Tm6o61Q==" -> "different hash"
!~ generation = 1761707842353772 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/target/manifest.json"
!~ md5hash = "w/s8aO2JrjlY5X2Tm6o61Q==" -> (known after apply)
name = "data/warehouse/target/manifest.json"
# (16 unchanged attributes hidden)
}
Plan: 0 to add, 7 to change, 0 to destroy.📝 Plan generated in Plan Terraform for Warehouse and DAG changes #887 |
21c54d2 to
0b07a5d
Compare
|
I think we would need to add the change (add a blank line before imports) on |
0b07a5d to
973e2cf
Compare
|
Terraform plan in iac/cal-itp-data-infra-staging/composer/us Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_composer_environment.calitp-staging-composer will be updated in-place
!~ resource "google_composer_environment" "calitp-staging-composer" {
id = "projects/cal-itp-data-infra-staging/locations/us-west2/environments/calitp-staging-composer"
name = "calitp-staging-composer"
# (5 unchanged attributes hidden)
!~ config {
# (8 unchanged attributes hidden)
!~ software_config {
!~ env_variables = {
- "CALITP_SLACK_URL_KEY" = (sensitive value) -> null
# (56 unchanged elements hidden)
}
# (6 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# (8 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.📝 Plan generated in Plan Terraform for Warehouse and DAG changes #887 |
Description
Updating precommit to the latest version and updating black as well.
Ran
pre-commit run -aand fixed most of the minor formatting issues (except the ones dealing withgtfs_rt_archiver_v3because that could cause issues).Resolves #4009
Type of change
How has this been tested?
pre-commit run -aIgnored
gtfs_rt_archiver_v3.Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.