Feature/merge layers with corner glyphs #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Can you split adding the corner legends to a separate PR? That would resolve #151. |
Owner
|
Thanks, I like the approach of a separate command to intentionally merge and output another keymap yaml. In general I am not a big fan of combined diagrams because they are hard to read, but it might be useful to have the functionality for some cases. I'll review if you can split as above. |
Contributor
Author
|
Awesome, will do. |
hollowhemlock
force-pushed
the
feature/merge-layers-with-corner-glyphs
branch
from
7a6b736 to
c34fe50
Compare
Contributor
Author
Contributor
Author
|
Also, I like the combined diagrams because they take less real estate when printing for easy reference. |
Owner
|
Can you rebase this when you get a chance? |
Contributor
Author
|
yeah |
Add a new subcommand that combines multiple layers into a single layer with multi-position legends. Each key can display: - Center (t/s/h): primary layer tap, shifted, and hold values - Corners (tl/tr/bl/br): tap values from up to 4 additional layers This enables creating compact reference diagrams showing multiple layers at once, useful for cheat sheets and documentation. New module: keymap_drawer/stack/ - stacker.py: Core stacking logic - config.py: StackConfig and CornerLayers models CLI usage: keymap stack-layers --center Base --tl Fun --tr Sys keymap.yaml Configuration options (stack_config): - corner_hide: Values to hide in corners - held_key_colors: Styling for layer activator keys - held_hide: Values to hide on held keys
hollowhemlock
force-pushed
the
feature/merge-layers-with-corner-glyphs
branch
from
c34fe50 to
cd3057b
Compare
Contributor
Author
|
Rebased to main and dropped the 1 commit related to #193. Ran the following and still functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#191 Pull request.