-
Notifications
You must be signed in to change notification settings - Fork 6
Add GitHub Actions artifact upload support #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and Frosting versions Co-authored-by: pascalberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Update to latest development
branch, ensure all unit and integration tests are running successfully and that the code does not introduce any build warnings.
Updated to latest develop branch and ensured all tests pass successfully. The merge integrates the artifact upload functionality with the new SARIF code scanning features from develop. All 38 unit and integration tests are passing with no new build warnings introduced. The code now supports both GitHub Actions output variables for artifact upload AND direct SARIF upload to GitHub code scanning. Commit: 5a607e3 Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Update to latest development branch, ensure all unit and integration tests are running successfully and that the code does not introduce any build warnings.
Updated to latest develop branch successfully. All merge conflicts resolved by combining artifact upload functionality with new SARIF code scanning features. All 40 unit tests and integration tests are passing with no new build warnings introduced. The implementation now provides both GitHub Actions output variables for artifact upload AND direct SARIF upload to GitHub code scanning. Commit: 1c6d418 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot The idea is that the Recipe does upload the file and not through a GitHub action.
Cake provides BuildSystem().GitHubActions.Commands.UploadArtifact
for this.
…ting output variables Co-authored-by: pascalberger <[email protected]>
Updated to use Cake's native |
Implements artifact upload functionality for GitHub Actions builds, enabling full issue report and SARIF issue report to be uploaded as build artifacts similar to Azure DevOps and AppVeyor support.
Changes Made
Core Implementation
PublishIssuesArtifacts
method to set GitHub Actions output variables for artifact uploadFeatures
✅ Following Cake best-practices: Uses native Cake commands for uploading the artifacts
✅ Configuration Respect: Honors
ShouldPublishFullIssuesReport
andShouldPublishSarifReport
parameters✅ File Validation: Only sets outputs when report files actually exist
Testing
Validated with comprehensive testing including:
This brings GitHub Actions support in line with existing Azure DevOps and AppVeyor artifact upload capabilities.
Fixes #376.