Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 5, 2025

Implements artifact upload functionality for GitHub Actions builds, enabling full issue report and SARIF issue report to be uploaded as build artifacts similar to Azure DevOps and AppVeyor support.

Changes Made

Core Implementation

  • GitHubActionsBuildServer.cake: Updated PublishIssuesArtifacts method to set GitHub Actions output variables for artifact upload
  • GitHubActionsBuildServer.cs: Mirror implementation for Cake.Frosting variant with proper imports and dual functionality

Features

✅ Following Cake best-practices: Uses native Cake commands for uploading the artifacts
✅ Configuration Respect: Honors ShouldPublishFullIssuesReport and ShouldPublishSarifReport parameters
✅ File Validation: Only sets outputs when report files actually exist

Testing

Validated with comprehensive testing including:

  • Normal operation with both report types
  • Edge cases (missing files, disabled publishing)
  • All 40 unit and integration tests passing
  • Build validation with no new warnings

This brings GitHub Actions support in line with existing Azure DevOps and AppVeyor artifact upload capabilities.

Fixes #376.

@Copilot Copilot AI changed the title [WIP] Upload full issue report as build artifact when running on GitHub Actions Add GitHub Actions artifact upload support for issue reports Jul 5, 2025
@Copilot Copilot AI requested a review from pascalberger July 5, 2025 17:30
Copilot finished work on behalf of pascalberger July 5, 2025 17:30
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Update to latest development branch, ensure all unit and integration tests are running successfully and that the code does not introduce any build warnings.

Copy link
Contributor Author

Copilot AI commented Aug 5, 2025

@copilot Update to latest development branch, ensure all unit and integration tests are running successfully and that the code does not introduce any build warnings.

Updated to latest develop branch and ensured all tests pass successfully. The merge integrates the artifact upload functionality with the new SARIF code scanning features from develop. All 38 unit and integration tests are passing with no new build warnings introduced. The code now supports both GitHub Actions output variables for artifact upload AND direct SARIF upload to GitHub code scanning. Commit: 5a607e3

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.myget.org
    • Triggering command: /usr/share/dotnet/dotnet restore Cake.Frosting.Issues.Recipe/Cake.Frosting.Issues.Recipe.sln --source REDACTED --source REDACTED /property:Version=5.8.0-copilot-fix-376-0001 /property:AssemblyVersion=5.8.0 /property:FileVersion=5.8.0 /property:AssemblyInformationalVersion=5.8.0-copilot-fix-376.1+22.branch.copilot-fix-376.sha.5a607e371be02c226eb6426aae77805f36d9630e /property:ContinuousIntegrationBuild=true /property:FrameworkPathOverride=/usr/bin/../lib/mono/4.5/ /property:Configuration=Release (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@pascalberger pascalberger marked this pull request as ready for review August 5, 2025 22:26
@Copilot Copilot AI changed the title Add GitHub Actions artifact upload support for issue reports Add GitHub Actions artifact upload support and integrate with SARIF code scanning Aug 5, 2025
@Copilot Copilot AI requested a review from pascalberger August 5, 2025 22:26
Copilot finished work on behalf of pascalberger August 5, 2025 22:26
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Update to latest development branch, ensure all unit and integration tests are running successfully and that the code does not introduce any build warnings.

Copy link
Contributor Author

Copilot AI commented Aug 11, 2025

@copilot Update to latest development branch, ensure all unit and integration tests are running successfully and that the code does not introduce any build warnings.

Updated to latest develop branch successfully. All merge conflicts resolved by combining artifact upload functionality with new SARIF code scanning features. All 40 unit tests and integration tests are passing with no new build warnings introduced. The implementation now provides both GitHub Actions output variables for artifact upload AND direct SARIF upload to GitHub code scanning. Commit: 1c6d418

@Copilot Copilot AI requested a review from pascalberger August 11, 2025 20:35
Copilot finished work on behalf of pascalberger August 11, 2025 20:35
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The idea is that the Recipe does upload the file and not through a GitHub action.

Cake provides BuildSystem().GitHubActions.Commands.UploadArtifact for this.

Copy link
Contributor Author

Copilot AI commented Aug 25, 2025

@copilot The idea is that the Recipe does upload the file and not through a GitHub action.

Cake provides BuildSystem().GitHubActions.Commands.UploadArtifact for this.

Updated to use Cake's native BuildSystem().GitHubActions.Commands.UploadArtifact directly instead of setting output variables for external actions. This approach is now consistent with AppVeyor and Azure DevOps build servers. Commit: c57f10c

@Copilot Copilot AI changed the title Add GitHub Actions artifact upload support and integrate with SARIF code scanning Use Cake's native artifact upload commands for GitHub Actions builds Aug 25, 2025
@Copilot Copilot AI requested a review from pascalberger August 25, 2025 22:45
Copilot finished work on behalf of pascalberger August 25, 2025 22:45
@pascalberger pascalberger changed the title Use Cake's native artifact upload commands for GitHub Actions builds Add GitHub Actions artifact upload support Aug 25, 2025
@pascalberger pascalberger merged commit 65c3598 into develop Aug 25, 2025
54 of 55 checks passed
@pascalberger pascalberger deleted the copilot/fix-376 branch August 25, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload full issue report as build artifact when running on GitHub Actions
2 participants