Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Commit

Permalink
Merge branch 'release/1.0.1'
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalberger committed Oct 7, 2021
2 parents 123a195 + 9f64345 commit c5b287b
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 2 deletions.
21 changes: 21 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
version: 2
updates:
- package-ecosystem: nuget
directory: "/src"
schedule:
interval: daily
time: "04:00"
open-pull-requests-limit: 10
ignore:
- dependency-name: Cake.Core
versions:
- "> 1.0.0, < 2"
- dependency-name: Cake.Testing
versions:
- "> 1.0.0, < 2"
- dependency-name: Cake.Issues
versions:
- "> 1.0.0, < 2"
- dependency-name: Cake.Issues.Testing
versions:
- "> 1.0.0, < 2"
2 changes: 1 addition & 1 deletion nuspec/nuget/Cake.Issues.GitRepository.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ See the Project Site for an overview of the whole ecosystem of addins for workin
<repository type="git" url="https://github.com/cake-contrib/Cake.Issues.GitRepository.git"/>
<copyright>Copyright © Pascal Berger</copyright>
<tags>cake cake-addin cake-issues cake-issueprovider code-analysis linting git</tags>
<releaseNotes>https://github.com/cake-contrib/Cake.Issues.GitRepository/releases/tag/1.0.0</releaseNotes>
<releaseNotes>https://github.com/cake-contrib/Cake.Issues.GitRepository/releases/tag/1.0.1</releaseNotes>
</metadata>
<files>
<file src="..\..\..\..\nuspec\nuget\icon.png" target="" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />
<PackageReference Include="xunit">
<Version>2.4.1</Version>
</PackageReference>
Expand Down
8 changes: 8 additions & 0 deletions src/Cake.Issues.GitRepository/GitRepositoryIssuesProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,14 @@ private IEnumerable<string> GetTextFilesFromRepository()
throw new Exception("Error reading text files from repository");
}

settings.Arguments.Clear();
settings.Arguments.Add("grep -IL .");
var emptyFiles = this.runner.RunCommand(settings);
if (emptyFiles != null && emptyFiles.Any())
{
textFiles = textFiles.Concat(emptyFiles);
}

this.Log.Verbose("Found {0} text file(s)", textFiles.Count());

return textFiles.ToList();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions tests/integration/tests.cake
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ Task("CheckBinaryFilesTrackedByLfs")
}),
new ReadIssuesSettings(repoRootDir));

if (issues.Any(i => i.AffectedFileRelativePath.GetFilename().ToString().Equals("empty.png", StringComparison.InvariantCultureIgnoreCase)))
{
throw new Exception("The empty files should not be treated as binary");
}

var reportDir =
repoRootDir.Combine("BuildArtifacts").Combine("TestResults").Combine("Integration");
var reportFilePath =
Expand Down

0 comments on commit c5b287b

Please sign in to comment.