Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Guides #102 #116

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Issue Guides #102 #116

merged 6 commits into from
Aug 19, 2024

Conversation

ninjeeter
Copy link
Collaborator

@Sytten
Workflow to add header + resend request

@render Render
Copy link

render bot commented Aug 18, 2024

Your Render PR Server URL is https://documentation-pr-116.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cr12i23tq21c73bp6js0.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 37.1%, saving 113.48 KB.

Filename Before After Improvement Visual comparison
src/_images/build.png 119.06 KB 74.33 KB -37.6% View diff
src/_images/finding_adding_header.png 103.85 KB 61.69 KB -40.6% View diff
src/_images/nodes_adding_header.png 83.07 KB 56.46 KB -32.0% View diff

137 images did not require optimisation.

Sytten
Sytten requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Sytten Sytten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Minor things to fix

.vitepress/sidebars/guides.ts Outdated Show resolved Hide resolved
src/guides/workflows/add_header.md Outdated Show resolved Hide resolved
src/guides/workflows/add_header.md Outdated Show resolved Hide resolved
src/guides/workflows/add_header.md Outdated Show resolved Hide resolved
src/guides/workflows/add_header.md Show resolved Hide resolved
@ninjeeter ninjeeter requested a review from Sytten August 19, 2024 03:30
@ninjeeter ninjeeter merged commit 9571876 into main Aug 19, 2024
4 checks passed
@ninjeeter ninjeeter deleted the AP-Guide-Workflow-Guide branch August 19, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sytten Sytten Sytten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninjeeter @Sytten