Fix missing logs (#5905)

cadence-workflow · Apr 12, 2024 · 5b27da0 · 5b27da0
1 parent 204d17f
commit 5b27da0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/service/history/execution/mutable_state_builder.go b/service/history/execution/mutable_state_builder.go
@@ -4819,7 +4819,7 @@ func (e *mutableStateBuilder) unixNanoToTime(
 }
 
 func (e *mutableStateBuilder) logInfo(msg string, tags ...tag.Tag) {
-	if e != nil {
+	if e == nil {
 		return
 	}
 	if e.executionInfo != nil {
@@ -4831,7 +4831,7 @@ func (e *mutableStateBuilder) logInfo(msg string, tags ...tag.Tag) {
 }
 
 func (e *mutableStateBuilder) logWarn(msg string, tags ...tag.Tag) {
-	if e != nil {
+	if e == nil {
 		return
 	}
 	if e.executionInfo != nil {
@@ -4843,7 +4843,7 @@ func (e *mutableStateBuilder) logWarn(msg string, tags ...tag.Tag) {
 }
 
 func (e *mutableStateBuilder) logError(msg string, tags ...tag.Tag) {
-	if e != nil {
+	if e == nil {
 		return
 	}
 	if e.executionInfo != nil {

diff --git a/service/history/execution/mutable_state_builder_test.go b/service/history/execution/mutable_state_builder_test.go
@@ -1864,3 +1864,11 @@ func TestAssignEventIDToBufferedEvents(t *testing.T) {
 		})
 	}
 }
+
+// This is only for passing the coverage
+func TestLog(t *testing.T) {
+	var e *mutableStateBuilder
+	assert.NotPanics(t, func() { e.logInfo("a") })
+	assert.NotPanics(t, func() { e.logWarn("a") })
+	assert.NotPanics(t, func() { e.logError("a") })
+}