Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add influxdb module #903

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Add influxdb module #903

merged 4 commits into from
Dec 20, 2023

Conversation

soebbing
Copy link
Contributor

Hi everybody!

This is my first attempt at a devenv module, to add support for InfluxDB.

I'm looking forward to some feedback!

@domenkozar
Copy link
Member

Two more things:

  • I'd name it config instead of settings so it's consistent with the other modules
  • we don't commit the lock file for examples

@soebbing
Copy link
Contributor Author

Lock file has been removed and I changed settings to config (hopefully in the right place). 😅

I took the ElasticMQ as an example https://github.com/cachix/devenv/blob/main/src/modules/services/elasticmq.nix#L18 - I think, that might need some changing as well.

@domenkozar
Copy link
Member

Seems like the test failed:

  • influx --execute 'CREATE DATABASE devenv'
    Failed to connect to http://localhost:8086: Get "http://localhost:8086/ping": dial tcp [::1]:8086: connect: connection refused
    Please check your connection settings and ensure 'influxd' is running.

@soebbing
Copy link
Contributor Author

Test is fixed! I forgot to set the port for the cli-command and it worked on my machine, since another influx instance was running on that port 🤦

@soebbing
Copy link
Contributor Author

At least I thought I had fixed the test. But I am unsure how to interpret these checks. InfluxDB seems to have been successful, but others failed?

@domenkozar
Copy link
Member

@soebbing
Copy link
Contributor Author

It should work on macOS (and I am using it right now). I do not see the warning: unknown setting 'ssl-cert-file' message locally, could be due to a difference in macOS version (I am on Sonoma 14.2).

Maybe the timeout was too short, I increased it to match the one in elasticMQ test https://github.com/cachix/devenv/blob/main/examples/elasticmq/.test.sh#L14

@soebbing
Copy link
Contributor Author

That seems to have done the trick! https://github.com/cachix/devenv/actions/runs/7250287690/job/19760416126

@domenkozar domenkozar merged commit 85f6e9c into cachix:main Dec 20, 2023
132 of 199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants