Skip to content

test(website): cover live production approval flows - #1098

Merged
blove merged 1 commit into
mainfrom
blove/production-approval-smoke
Sep 14, 2026
Merged

blove merged 1 commit into
mainfrom
blove/production-approval-smoke

Conversation

@blove

@blove blove commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Production page and endpoint checks could pass while an invalid provider key caused an HTTP-200 agent stream to close without a reply. Add five live canaries to the existing post-deployment smoke suite: refund approval/cancellation, Mastra reservation approval/cancellation, and an AG-UI demo reply.

Each requires RUN_FINISHED and rejects RUN_ERROR. Approval cases verify the dialog payload, submitted decision, dialog closure, and matching result; Mastra also correlates the resumed tool result. These checks use deployed credentials and do not skip when the runner lacks a local provider key. Sequential execution, one retry, and 120-second test timeouts bound provider usage.

Validation:

  • All five production canaries passed twice against live services.
  • A temporary HTTP-200 truncated stream failed immediately at the missing RUN_FINISHED assertion; interception was removed before the second successful live run.
  • Website lint passed with existing warnings; changed-file lint and formatting passed.
  • Normal Playwright selection excludes the production spec.
  • Chrome verification confirmed a completed refund approval and reservation cancellation.
  • Independent review found no actionable issues.

No public API or documentation behavior changes.

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 14, 2026 3:21am UTC

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove enabled auto-merge (squash) September 14, 2026 03:18
@blove
blove merged commit 41d098d into main Sep 14, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant