chore(website): remove the cockpit retirement spec - #1085
Merged
Merged
Conversation
The cockpit → unified-docs migration is finished: no cockpit/**/docs/guide.md walkthroughs remain, no capability descriptor declares docsAssetPaths, and cockpit.threadplane.ai appears nowhere in the website outside specs asserting its own absence. This deliberately gives up two guards that were still live, so recording what goes unenforced from here: - cockpit.threadplane.ai may reappear in website links and authored content. - "Cockpit", the retired product name, may reappear in user-facing .mdx/.md/ .tsx. The spec had been arbitrating this across a dozen content files, allowing legitimate technical tokens — repo paths like cockpit/ag-ui/ interrupts, package names like @threadplane/cockpit-registry, Nx targets like serve:cockpit — while barring the bare product name. The cockpit/ workspace is still very much alive, so the source of that leakage remains. public-copy.spec.ts does not backstop either one; it covers barred absolute claims, telemetry positioning and retired docs routes. Also retires the cwd bug that made this file fail whenever vitest ran from anywhere but the repo root: it resolved its roots with join(process.cwd(), 'apps/website') instead of the sibling convention resolve(__dirname, '../..'), so a targeted run reported five red herrings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
enabled auto-merge (squash)
September 9, 2026 04:01
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cockpit → unified-docs migration is finished, so the spec that guarded it is retired. Verified before removal: no
cockpit/**/docs/guide.mdwalkthroughs remain, no capability descriptor declaresdocsAssetPaths, andcockpit.threadplane.aiappears nowhere in the website outside specs asserting its own absence.This deliberately gives up two guards that were still live. Recording what goes unenforced from here, because the file's name undersold what it did:
cockpit.threadplane.aimay reappear in website links and authored content..mdx/.md/.tsx. The spec had been arbitrating this across a dozen content files — allowing legitimate technical tokens (repo paths likecockpit/ag-ui/interrupts, package names like@threadplane/cockpit-registry, Nx targets likeserve:cockpit) while barring the bare product name. Thecockpit/workspace is still very much alive, so the source of that leakage remains in the tree.public-copy.spec.tsdoes not backstop either one — it covers barred absolute claims, telemetry positioning and retired docs routes.It also takes a long-standing annoyance with it. The file resolved its roots with
join(process.cwd(), 'apps/website')rather than the sibling conventionresolve(__dirname, '../..'), so it doubled the prefix intoapps/website/apps/websiteand reported five red herrings whenever vitest ran from anywhere but the repo root. Three plan documents carry workaround notes about exactly that; they are historical records and are left as-is.@threadplane/cockpit-registrystays — eight other website files import it.Test Plan
npx nx test websitegreennpx nx lint website— 0 errorstsc --noEmit— no orphaned references🤖 Generated with Claude Code