Conversation
Phase 3 of 4 for B2 comparative bench. Replaces the placeholder mui-adapter shell from Phase 1 with a real MUI X DataGrid Community v7 implementation using idiomatic out-of-the-box config: <DataGrid> with hideFooter, default density, getRowId, scriptName-driven valueFormatter and renderCell branches for scroll-with-format / scroll-with-render / scroll-with-heavy-render. No Premium features. Adds @mui/x-data-grid@^7, @mui/material@^5, @emotion/react@^11, @emotion/styled@^11 to apps/bench only — no leakage to @pretable/* public-surface packages. Smoke test asserts on .MuiDataGrid-virtualScroller (the same selector the bench-runtime profile uses), with documented fallback to .MuiDataGrid-root if a future jsdom/MUI bump drops the scroller node. Spec: docs/superpowers/specs/2026-05-08-tier1-b2-comparative-bench-design.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Why: code review flagged the [runKey]-only dep array as a stale-closure risk. The contract (bench-app's useCallback + ref-sync at render) makes this safe; comment makes the contract explicit. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Vercel preview readyPreview: https://pretable-frnozkbk5-cacheplane.vercel.app Updated automatically by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of 4 for Tier 1 B2 comparative bench.
Replaces the placeholder
mui-adapter.tsx(shipped in Phase 1) with a real MUI X DataGrid Community v7 adapter:<DataGrid>withhideFooter,disableRowSelectionOnClick, default density,getRowId, sortable + filterable + resizable columns. No Premium-tier features.scriptName-drivenvalueFormatter(scroll-with-format) andrenderCell(scroll-with-render/scroll-with-heavy-render) branches mirror the AG Grid adapter shape.useState+ map merge) — Community tier has no transaction API; this is the honest baseline called out in the spec.Adds
@mui/x-data-grid@^7,@mui/material@^5,@emotion/react@^11,@emotion/styled@^11toapps/benchonly — no leakage to@pretable/*public-surface packages.Test surface
Smoke test asserts on
.MuiDataGrid-virtualScroller(the same selector the bench-runtime profile uses as the viewport) with.MuiDataGrid-rootdocumented inline as a fallback for class-name drift on minor MUI bumps.What's NOT in this PR
Test plan
🤖 Generated with Claude Code