fix(release): preserve runtime environment boundary - #532
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, aligns with the documented adapter contract (omit environment when unspecified), and is covered by targeted multi-mode regressions plus full validation.
Pull request overview
This PR fixes the duplicate-draft consolidation CLI’s adapter-composition boundary so it preserves whether the caller explicitly supplied an environment option, instead of implicitly defaulting to process.env and forwarding it into the “explicit override” adapter path.
Changes:
- Update the CLI option normalization to only include
environmentwhen it was explicitly provided by the caller. - Centralize adapter-composition option building (including conditional
environmentandrequestBudget) acrossinspect,perform, andverify. - Add a table-driven regression test covering omitted vs explicit (frozen) vs explicit
undefinedenvironment handling across all modes, including the two-stepperformadapter composition.
File summaries
| File | Description |
|---|---|
| scripts/release/duplicate-draft-consolidation-cli.mjs | Preserves environment option presence and uses a shared adapter-composition helper across all CLI modes. |
| scripts/release/test/duplicate-draft-consolidation-cli.test.mjs | Adds a table-driven regression ensuring the CLI omits implicit environment and preserves explicit environment presence/identity across modes. |
| docs/superpowers/specs/2026-09-02-consolidation-runtime-environment-design.md | Documents the problem/decision to omit implicit environment at the CLI→adapter boundary. |
| docs/superpowers/plans/2026-09-02-consolidation-runtime-environment.md | Records the implementation plan and verification steps for the environment-boundary fix. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Release Notes
Screenshots Or Artifacts
Checklist