Skip to content

fix(release): preserve runtime environment boundary - #532

Merged
blove merged 1 commit into
mainfrom
blove/fix-consolidation-runtime-environment
Sep 2, 2026
Merged

fix(release): preserve runtime environment boundary#532
blove merged 1 commit into
mainfrom
blove/fix-consolidation-runtime-environment

Conversation

@blove

@blove blove commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve whether the consolidation CLI caller explicitly supplied an environment
  • let production adapter composition own its existing runtime snapshot when the environment is omitted
  • cover inspect, perform, and verify, including explicit frozen and explicit undefined inputs plus perform request budgets

Validation

  • pnpm lint
  • pnpm build
  • pnpm typecheck
  • pnpm test
  • node scripts/check-docs.mjs
  • pnpm pack:check
  • DAWN_REQUIRE_DOCKER=1 pnpm ci:validate
  • focused consolidation suite: 594/594 tests
  • harness framework, runtime, and smoke lanes

Release Notes

  • Changeset not needed: this is an internal release-operations correction and changes no published package behavior.

Screenshots Or Artifacts

  • Harness run: harness-2026-09-02T152524-212Z-46021

Checklist

  • I read CONTRIBUTING.md.
  • I followed CODE_OF_CONDUCT.md.
  • I did not include secrets, credentials, or private data.
  • I am not disclosing a security vulnerability publicly.

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dawnai Ready Ready Preview Sep 2, 2026 3:36pm UTC

Request Review

@blove
blove requested a lite review from Copilot September 2, 2026 15:35

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is narrowly scoped, aligns with the documented adapter contract (omit environment when unspecified), and is covered by targeted multi-mode regressions plus full validation.

Pull request overview

This PR fixes the duplicate-draft consolidation CLI’s adapter-composition boundary so it preserves whether the caller explicitly supplied an environment option, instead of implicitly defaulting to process.env and forwarding it into the “explicit override” adapter path.

Changes:

  • Update the CLI option normalization to only include environment when it was explicitly provided by the caller.
  • Centralize adapter-composition option building (including conditional environment and requestBudget) across inspect, perform, and verify.
  • Add a table-driven regression test covering omitted vs explicit (frozen) vs explicit undefined environment handling across all modes, including the two-step perform adapter composition.
File summaries
File Description
scripts/release/duplicate-draft-consolidation-cli.mjs Preserves environment option presence and uses a shared adapter-composition helper across all CLI modes.
scripts/release/test/duplicate-draft-consolidation-cli.test.mjs Adds a table-driven regression ensuring the CLI omits implicit environment and preserves explicit environment presence/identity across modes.
docs/superpowers/specs/2026-09-02-consolidation-runtime-environment-design.md Documents the problem/decision to omit implicit environment at the CLI→adapter boundary.
docs/superpowers/plans/2026-09-02-consolidation-runtime-environment.md Records the implementation plan and verification steps for the environment-boundary fix.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@blove
blove merged commit 7874676 into main Sep 2, 2026
42 of 44 checks passed
@blove
blove deleted the blove/fix-consolidation-runtime-environment branch September 2, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants