fix(website): AnnouncementToast mobile presentation and a11y - #877
Merged
Conversation
blove
enabled auto-merge (squash)
August 30, 2026 20:09
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
The remaining two toast items from the polish-arc deferred list: - Mobile width (findings §6): below 480px the 360px right-hugging card covered 327px of a 375px screen; it now presents as a centered bottom sheet with even 16px margins and tighter padding. - A11y: the root was role=alert + aria-live on interactive content (CTA button and email form) — now a non-modal role=dialog labelled by the title, which never steals focus on entry. Escape dismisses once focus is inside. The close button gets a hover state, a focus-visible ring, and a 44px hit target via ::after (findings §7). The 'sent' success message is role=status so the step swap is still announced. Verified in-browser at 375: 16px margins, close hit 46x50, Escape dismisses and persists the dismissal. nx test green, lint 0 errors, production build green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
force-pushed
the
blove/toast-polish
branch
from
August 30, 2026 20:14
d1d7e82 to
f602307
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last two toast items from the polish-arc deferred list:
role="alert"+aria-livewrapped around interactive content (the CTA button and email form) — an alert/live region must not hold interactive controls. It's now a non-modalrole="dialog"labelled by the title, which never steals focus on entry. Escape dismisses once focus is inside (and persists the dismissal). The close button gains a hover state, a:focus-visiblering, and a 44px touch target via::after(findings §7) without visual growth. The "sent" success message isrole="status"so the step swap is still announced to screen readers.Verification
Browser-measured at 375: toast rect
left: 16 / right: 359(even margins), close hit target 46×50, Escape firesdismiss()and sets the localStorage key,role/aria-labelledbypresent.nx test websitegreen, lint 0 errors, production build green (exit codes verified).🤖 Generated with Claude Code