fix(mastra): verify cancellation outcomes with aimock - #1086
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
blove
enabled auto-merge (squash)
September 9, 2026 04:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a campsite reservation returned the correct backend decline but replayed an approval message because both outcomes shared one aimock fixture. Reservation continuations now match the actual tool result, and cancellation uses a reply captured from the live model.
The browser tests verify both decisions, their correlated resume commands and backend results, and the visible assistant outcome. The Mastra harness now supports the shared aimock replay/record configuration. Recording instructions require a fresh process per decision because newly recorded responses are cached with broad matchers.
Validation: all six Mastra replay scenarios pass; approval and cancellation each pass against the live model through separate aimock recording processes; the E2E wiring checks pass. An isolated Chrome MCP session also verified live cancellation from the approval dialog through the backend decline to the visible non-booking reply. Code review found no remaining issues. No external reservations are made by this local demonstration tool.