Fix interactive regex_block flow to prompt for pattern#67
Merged
Conversation
Rename the spam profile pattern management feature from "SpamPattern" to "SpamReact" to distinguish it from existing content filtering patterns. Nest help content under the Owner section instead of a standalone top-level button. Commands: /addspamreact, /removespamreact, /listspamreacts, /testspamreact, /spamreacthelp
The interactive /addrestriction flow for regex_block never asked for the actual pattern to filter. After selecting auto-jail settings it saved the restriction with no action, resulting in an empty regex_block entry. Add step 4 to the session flow that prompts for the pattern before applying. Extract shared applyRestriction helper for the final save/log/confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/addrestrictionflow forregex_blocknever prompted for the actual pattern to filter, saving restrictions withAction: N/AapplyRestriction()helper for the final save/log/confirm logicTest plan
/addrestrictioninteractively, select Regex Block, verify it prompts for the pattern after auto-jail selection/listrestrictionsbun run testpasses (36/36)