Fix MineProcess stalling on blocks which are canWalkThrough but shouldn't be broken
#4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaft-mining checks `avoidBreaking` so not checking it here can cause Baritone to walk to a position and then do nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before breaking a block,
MineProcesschecksMovementHelper.avoidBreakingto avoid falling blocks and similar problems. Normally it also does that check before setting the goal implicitly viaMovementHelper.getMiningDurationTicks. However that method (correctly) short-circuits forcanWalkThroughblocks so such blocks could end up in the goal, even if they cannot be mined.Note: This fixes the linked issue by completely ignoring blocks next to the world border, which is consistent with the pathfinder and mining solid blocks. Doing so might be considered a bug, because those blocks are breakable.
Fixes #4654