Fix nether-pathfinder with optimized forge/neoforge builds #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot distinguish between unsupported systems and failures on supported systems so strongly implying the former is potentially misleading.
|
Requires #4659 for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shadow the java part of netherpathfinder on forge and neoforge and we do so before running proguard.
Since
PathSegments are only ever constructed via JNI by libnether-pathfinder proguard determines thatPathSegmentis never instantiated at all and rips out the constructor, making the game crash for obvious reasons.Nether-pathfinder also seems to have a slight problem with it's logging, since the messages it prints don't make it into the log file.
Funnily, proguard now prints a message that explicitly keeping library classes is not needed.
Fixes #4656