-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.19.4 into 1.20.5 #4527
Merged
Merged
Merge 1.19.4 into 1.20.5 #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixinAndAsm Sync mixin and asm versions between common and tweaker
The class doesn't even exist in the version of Litematica I'm using so it doesn't seem to have an effect on descriptor strings in our bytecode. Otherwise my game would crash.
…litematicaRework Almost rewrite litematic handling
…ateAndMirrorSchematics Add settings to rotate/mirror schematics
Fix not moving from edge of block
4 tasks
`minecraft:moving_piston` is the only block I currently know which could cause this to crash.
They also have to be removed rather than ignored because they won't be scanned again and would stay in `incorrectPositions` indefinitely.
(sorry, misclick) |
…EmptyShapeCrash Don't call `shape.bounds()` on empty shapes
…PositionOutOfBounds Handle positions going out of bounds between ticks
…WalkOnSoulSand Allow walking on soul sand once again
ZacSharp
force-pushed
the
1.20.5-update
branch
from
October 21, 2024 19:54
fd8af9b
to
94a6b85
Compare
ZacSharp
force-pushed
the
1.20.5-update
branch
from
October 22, 2024 22:37
94a6b85
to
2869503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
shape.bounds()
on empty shapes #4529)Note: This is for Minecraft 1.20.6. Why is the branch called 1.20.5?