Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chromoscope link to pancan_pcawg_2020 #2052

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

michandreop
Copy link

Comments

  • Created a link for every Patient ID in the clinical data to the Chromoscope website (chromoscope)
  • Used Resource Data files to link them inside the patient

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @michandreop! Great work! Would you be able to connect each Chromoscope resource to a sample rather than a patient? Thank you!

@michandreop
Copy link
Author

Hi @inodb! Please find the requested change under the commit with ID: [23a3c0e]

@inodb
Copy link
Member

inodb commented Aug 30, 2024

Thanks so much @michandreop ! To fix the commit history you can generally do something like:

# get the original clone (check if git remote -v is pointing to your repo) 
git checkout origin/master -b chromoscope-fix
# cherry pick your change with the right changes
git cherry-pick 23a3c0ec136abeabc51fb759fcbc5be84bf6645a
# override your existing PR (note that your fork should be in git remote -v for this to work)
git push michandreop --force chromoscope-fix:chromoscope

We can def work with this on our end so need to change but just FYI - thought maybe helpful to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants