Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javax dependency #10688

Closed
wants to merge 1 commit into from
Closed

javax dependency #10688

wants to merge 1 commit into from

Conversation

dippindots
Copy link
Member

introduce javax dependency

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JREastonMarks JREastonMarks self-requested a review March 6, 2024 21:56
Copy link
Contributor

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure why this needed when we haven't had to bring it in yet.

@dippindots
Copy link
Member Author

@JREastonMarks This is related to the issue we see on the M series chip laptop when running v6 cbioportal-docker-compose
CC: @alisman

@haynescd
Copy link
Collaborator

@dippindots How did you test this?

I propose just updating the deps in pom to be scoped to test
org.testcontainers.mockserver
org.mock-server.mockserver-client-java

@alisman
Copy link
Contributor

alisman commented Mar 12, 2024

@haynescd we tested this by creating a docker image based on the branch and then building localdb based on that image. It resolved the error we were seeing on our m2 machines (but not elsewhere). You are welcome to try to fix this in another fashion.

@haynescd
Copy link
Collaborator

@alisman ok, awesome will do. I just don't think the mockserver should even be apart of the production build (which seems to be what pulls that need for the dep in)

This is all strange how its only on m1/m2 chips

@alisman alisman closed this Mar 18, 2024
@alisman alisman deleted the demo-javax branch March 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants