Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mutation Data Counts Endpoint on Mutation Tables and Rename Return Types #10665

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Fix Mutation Data Counts Endpoint on Mutation Tables and Rename Return Types #10665

merged 8 commits into from
Mar 7, 2024

Conversation

7xuanlu
Copy link
Contributor

@7xuanlu 7xuanlu commented Feb 23, 2024 •
edited
Loading

Fix Frontend Related PR: cBioPortal/cbioportal-frontend#4794

  • Filter mutation counts data on pie chart (MUTATED) but not table (MUTATION_TYPE)
  • Rename WILD_TYPE -> NOT_MUTATED, NA -> NOT_PROFILED
  • Rename EVENT -> MUTATION_TYPE
    Screenshot 2024-02-23 at 12 55 02 PM

@7xuanlu 7xuanlu self-assigned this Feb 23, 2024
JREastonMarks
JREastonMarks approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let me know when you want me to merge it in

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JREastonMarks JREastonMarks merged commit e37d196 into master Mar 7, 2024
17 of 18 checks passed
@JREastonMarks JREastonMarks deleted the mutation-data-counts branch March 7, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalletlak kalletlak kalletlak approved these changes

@JREastonMarks JREastonMarks JREastonMarks approved these changes

Assignees

@7xuanlu 7xuanlu

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@7xuanlu @JREastonMarks @kalletlak @qlu-cls