Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexes to database scheme #10432

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Oct 11, 2023

Fix cBioPortal/icebox#469 #10411

This pr fixes two things:

  1. The scheme is out of sync between cgds.sql and migration.sql, sync it again
  2. Put a limit on VALUE field in clinical_event_data table to avoid the key overlength issue (max key length is 3072 bytes, for MySQL 8 default character set utf8mb4, max characters length are 768)

@inodb
Copy link
Member

inodb commented Oct 12, 2023

Maybe good to look at this and see if we can make a proper fix: #10411

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JREastonMarks
Copy link
Contributor

Hi @dippindots ,
Can you rebase this off of master to address the changes that came with 6.0.0? I will be glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema out of sync in public portal and MSK portal
3 participants