Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements to jupyter modal #10949 #4968

Merged

Conversation

gautamsarawagi
Copy link
Contributor

Fix cBioPortal/cbioportal#10949

Describe changes proposed in this pull request:

  • Properly formatter the code of Modal (Took out the Modal.Footer code out of Modal.Body).

Any screenshots or GIFs?

image

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit ce9b799
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66c38dde4428cd00076f9a43
😎 Deploy Preview https://deploy-preview-4968--cbioportalfrontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman alisman merged commit b1a387c into cBioPortal:master Aug 19, 2024
11 of 15 checks passed
@dippindots dippindots added the style tweak To indicate the PR does a minor style tweak label Sep 10, 2024
@inodb inodb added the gsoc label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc style tweak To indicate the PR does a minor style tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refinements to the Jupyter modal
4 participants