add alternate configuration so "web" images (app.jar) can be loaded in docker #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
Here is a dev experience following the documentation:
If the dev wants to test with the "app.jar" image, which mirrors the actual production deployment, the steps would not work:
FIX
This PR adds an alternate docker configuration (YML) that instead loads the image and executes the app.jar. So the user needs to do:
RELATED
Still need to update the cbioportal repo documentation. That will be a separate PR.
FURTHER WORK
Copy-pasting the docker-compose.yml is not very maintainable. There is probably much better solution to this that someone familiar with docker configurations can address.
For example, is the "command:" line really necessary, since each image has it's own Dockerfile that can define what should be executed? Is it only in place for the "rm servlet-api-2.5.jar" hack? Is that still necessary?
REVIEW
@alisman