test: add webapp first-run e2e coverage - #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2epytest markerwebapp/setup.shfromnpm installtonpm ciscripts/e2e/run-core-e2e.shdocs/e2e.mdto describe lane overlap and the expanded core harness coverageE2E coverage
Task #27 covers the docs/webapp E2E lane:
make devconfig fallback commanduv sync --extra webappnpm ci && npm run builduv run agfs-shell --webappsubprocess with HTTP fetch of/scripts/e2e/run-core-e2e.shnow runs this lane as part of the shared gateReview
Cross-review PASS from @dev-2 in Slock task #27. Final review used the v2 patch that integrates with the task #24 shared harness.
Verification
git diff --check HEAD~1..HEADPYTHONPATH=. .venv/bin/python -m pytest tests/test_webapp_server.py tests/test_docs_webapp_e2e.py -v --timeout=15-> 2 passed, 1 skippedAGFS_RUN_E2E=1 PYTHONPATH=. .venv/bin/python -m pytest tests/test_docs_webapp_e2e.py -v --timeout=180-> 1 passedscripts/e2e/run-core-e2e.sh-> core e2e passed, including docs/webapp lanePart of stability issue #21. Closes task #27.