Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to clear associations first? #1117

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Conversation

brunobesson
Copy link
Member

A fix for #1116?

Blind guess...

Copy link
Member

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an unit test on this function?

blind guess scares me a little :)

@brunobesson
Copy link
Member Author

Is there an unit test on this function?

There is. I thought I couldn't update it because there was already an association, but with a closer look today, there was an area association, not a map association. Let's see how it goes now.

@brunobesson brunobesson force-pushed the merge-georeferenced-user branch 5 times, most recently from b011080 to 209708e Compare July 12, 2021 11:32
@lbesson
Copy link
Member

lbesson commented Jul 12, 2021

Blind guessing the unit tests 😁

@brunobesson
Copy link
Member Author

@lbesson totally. Mind to fix it?

@brunobesson brunobesson force-pushed the merge-georeferenced-user branch 4 times, most recently from ee703d2 to 88adf52 Compare July 12, 2021 11:55
@brunobesson
Copy link
Member Author

Please review.

@brunobesson brunobesson merged commit 7e5edab into master Jul 13, 2021
@brunobesson brunobesson deleted the merge-georeferenced-user branch July 13, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants