Shell command hangs with long-running tasks #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This change ensures that long-running shell commands (such as programs that produce infrequent or delayed standard output) do not cause the tool to hang indefinitely while waiting for output.
More Information
Replaced direct access to self._process.stdout._buffer.decode() with await self._process.stdout.readline() for safe incremental reading.
Accumulates stdout content line by line into a local output buffer.
Retains the original sentinel-based error_code detection mechanism (,,,,bash-command-exit-ERROR_CODE-banner,,,,).
Maintains compatibility with both Unix-like and Windows shells.
Preserves stderr reading and timeout handling.
Validation
Linked Issues