Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl IO for some foreign types; rewrite readv/writev impl for some types #313

Merged
merged 2 commits into from
Oct 29, 2024
Merged

feat: impl IO for some foreign types; rewrite readv/writev impl for some types #313

merged 2 commits into from
Oct 29, 2024

Conversation

ihciah
Copy link
Member

@ihciah ihciah commented Oct 28, 2024

  1. Add AsyncReadRent impl for Cursor<T>, Box<T>; AsyncWriteRent for Vec<u8>
  2. Rewrite readv for &[u8]
  3. Impl AsyncReadRentAt/AsyncWriteRentAt for &mut A when A implements the coresponding trait
  4. Small change: change async move { .. } to std::future::ready(..)

Related issue: #310

@ihciah ihciah self-assigned this Oct 28, 2024
@ihciah ihciah marked this pull request as draft October 28, 2024 08:48
@ihciah ihciah force-pushed the io-for-foreign-types branch from 6ceee61 to 8e4f859 Compare October 28, 2024 08:54
@ihciah ihciah force-pushed the io-for-foreign-types branch from 8e4f859 to 8cfd02e Compare October 28, 2024 08:57
@ihciah ihciah marked this pull request as ready for review October 29, 2024 06:42
@ihciah ihciah requested a review from Lzzzzzt October 29, 2024 07:01
Lzzzzzt
Lzzzzzt approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@Lzzzzzt Lzzzzzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@Lzzzzzt Lzzzzzt merged commit 8a8ad70 into bytedance:master Oct 29, 2024
25 checks passed
@SteveLauC
Copy link
Contributor

Thanks for the impl! I just turned #310 into a tracking issue to track the progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lzzzzzt Lzzzzzt Lzzzzzt approved these changes

Assignees

@ihciah ihciah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ihciah @SteveLauC @Lzzzzzt