Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker file for building infinistore and instructions in README.md #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hhzguo
Copy link

@hhzguo hhzguo commented Feb 24, 2025

The Dockerfile for building infinistore project in a docker container

@hhzguo hhzguo force-pushed the henry/docker_build branch from 7ef969f to 0c2da1d Compare February 24, 2025 18:04
@hhzguo hhzguo requested a review from thesues February 24, 2025 18:05
Dockerfile Outdated
ENV DEBIAN_FRONTEND=noninteractive

# Install necessary build dependencies and dependencies for Python 3.12
RUN dnf install -y python3.12 python3.12-pip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manylinux pre-installed python. such as /opt/python/cp312-cp312/bin/python3.12. you can try to build wheel package by this script build_manylinux_wheels.sh

Dockerfile Outdated
WORKDIR boost_${BOOST_VERSION_UNDER}

# 配置 Boost
# 注意:这里使用 layout=system 以确保库文件安装在标准位置
Copy link
Collaborator

@thesues thesues Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use english comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Dockerfile Outdated

# 配置 Boost
# 注意:这里使用 layout=system 以确保库文件安装在标准位置
RUN ./bootstrap.sh --prefix=${INSTALL_PREFIX} --with-libraries=system,filesystem,thread,program_options,chrono,regex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think stacktrace is missing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install boost from public now

-j$(nproc) \
--layout=system
# Somehow the above doesn't build boost_stacktrace_basic, so install it
RUN dnf install -y boost boost-devel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you could install boost-devel directly, so it is not necessary to build boost anymore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hhzguo hhzguo force-pushed the henry/docker_build branch from 0c2da1d to 2c09e08 Compare February 27, 2025 23:33
RUN yum -y install rdma-core-devel libuv-devel

# The cuda is not available from dnf sources and have to download and install manually
RUN curl -O https://developer.download.nvidia.com/compute/cuda/12.8.0/local_installers/cuda-repo-rhel8-12-8-local-12.8.0_570.86.10-1.x86_64.rpm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda will be removed ;-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean cuda could be removed from the installation list?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


henry.guo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants