Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally generate the drop function for borrows in c #793

Merged

Conversation

elliottt
Copy link
Member

This PR makes two changes to resource handling in C:

  1. Fixes the signature for the _drop_borrow function, making it take a borrow struct instead of an own struct,
  2. Doesn't generate the drop function for borrows when generating code for exports (borrows are typedef'd as a pointer in this case, so this was not possible before)

@alexcrichton alexcrichton merged commit 1c5d94f into bytecodealliance:main Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants