Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): add default value for async usage #1127

Conversation

vados-cosmonic
Copy link
Contributor

This commit introduces a default value for the --async option as used with Rust bindgen.

At present when using wit-bindgen the --async argument is required:

wit-bindgen rust test.wit --out-dir output
error: the following required arguments were not provided:
  --async <ASYNC>

Usage: wit-bindgen rust --async <ASYNC> --out-dir <OUT_DIR> <WIT>

For more information, try '--help'.

This commit introduces a default value for the `--async` option as
used with Rust bindgen.

Signed-off-by: Victor Adossi <[email protected]>
@vados-cosmonic vados-cosmonic force-pushed the refactor(rust)=remove-async-required-argument branch from 27b8baf to a02c20f Compare January 16, 2025 14:26
Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dicej dicej added this pull request to the merge queue Jan 16, 2025
Merged via the queue into bytecodealliance:main with commit 5905093 Jan 16, 2025
25 checks passed
@vados-cosmonic vados-cosmonic deleted the refactor(rust)=remove-async-required-argument branch January 17, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants