Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error-context.{new,debug-message} helpers #1126

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

vados-cosmonic
Copy link
Contributor

This commit adds helpers for new error-context canon functions that are part of the WASI P3 async effort.

The implementations here have been tested for integration in wasmtime, currently targeting the dicej/wasmtime repository's async branch on wasmtime.

A PR has been opened downstream (currently in draft as more tests are added) that demonstrates these changes in the context of the wasmtime VM

@alexcrichton alexcrichton requested a review from dicej January 15, 2025 15:25
Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one comment about buffer alignment.

This commit adds helpers for new `error-context` canon functions that
are part of the WASI P3 async effort.

Signed-off-by: Victor Adossi <[email protected]>
Co-authored-by: Joel Dice <[email protected]>
@dicej dicej enabled auto-merge January 15, 2025 17:25
@dicej dicej added this pull request to the merge queue Jan 15, 2025
Merged via the queue into bytecodealliance:main with commit 341c473 Jan 15, 2025
25 checks passed
@vados-cosmonic vados-cosmonic deleted the feat=error-context-new branch January 15, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants