Skip to content

[32.0.0] Fix tables holding their registered types #11106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jun 23, 2025

This is a backport of #11103 to the 32.0.0 release branch

Note that while this branch is technically now supported it's been "out of support" for so little time I figure it's easy enough to go ahead and patch anyway.

This commit fixes an issue where host-created tables with concrete
reference types previously did not keep their associated type
registrations alive for the duration of the table itself. This could
lead to runtime panics when reflecting on their type and additionally
lead to some type confusion about the table itself.  As described
in bytecodealliance#11102 this is not a security issue, just a bug that needs fixing.

Closes bytecodealliance#11102
@alexcrichton alexcrichton requested a review from a team as a code owner June 23, 2025 16:17
@alexcrichton alexcrichton requested review from pchickey and removed request for a team June 23, 2025 16:17
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jun 23, 2025
@alexcrichton alexcrichton merged commit 7a5784e into bytecodealliance:release-32.0.0 Jun 24, 2025
154 checks passed
@alexcrichton alexcrichton deleted the back32 branch June 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants