feat(cranelift): Use DominatorTreePreorder in more places #11098
+40
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomInTheWire
requested review from
alexcrichton
and removed request for
a team
github-actions
bot
added
the
cranelift
alexcrichton
requested review from
a team and
cfallin
and removed request for
alexcrichton and
a team
|
I'm going to reroll this on the compiler-reviewer rotation as I'm not familiar with this data structure, but I suspect others are! |
cfallin
reviewed
Jun 23, 2025
PhantomInTheWire
force-pushed
the
feat/use-dominator-tree-preorder
branch
from
3e8e190 to
1a5bc48
Compare
PhantomInTheWire
force-pushed
the
feat/use-dominator-tree-preorder
branch
from
1a5bc48 to
5906724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to audit and reduce usage of
DominatorTreeand itsdominates()method, as tracked in #7954 goal is to replace these withDominatorTreePreorderwherever applicable.Context
Recent related work includes: