Bump wasmtime to version 32
#457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulecabrera
commented
May 22, 2025
| wasmtime-environ = "=31.0.0" | ||
| deterministic-wasi-ctx = "=0.1.34" | ||
| wasmtime-environ = "=32.0.0" | ||
| deterministic-wasi-ctx = { version = "=1.2.0", features = ["wasi-common"] } |
There was a problem hiding this comment.
Until #448 is merged.
saulecabrera
commented
May 22, 2025
| @@ -18,7 +18,7 @@ module Wasmtime | |||
| it "includes the backtrace" do | |||
| expect(trap.wasm_backtrace_message).to eq(<<~MSG.rstrip) | |||
| error while executing at wasm backtrace: | |||
| 0: 0x1a - <unknown>!<wasm function 0> | |||
| 0: 0x1a - <unknown>!<wasm function 0> | |||
There was a problem hiding this comment.
The formatting here changed a bit, I wasn't able to pinpoint if this is intentional in upstream wasmtime though.
|
Ugh, I think the failures are related to linking. |
|
Changes so far look good to me. But interested in seeing what the fix for not being able to find |
jeffcharles
approved these changes
Jun 3, 2025
|
The issues in rb-sys were fixed upstream (thanks Jeff!), so the Windows issues are now fixed. There's one Valgrind issue that is currently under investigation, so I'm proposing that we merge on red, and follow-up with a fix after the fact. |
New versions of `rustix` don't use libc by default. bytecodealliance/rustix#1389
|
Memcheck issue was fixed in 20fb455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.