[UNIT]tests: add wasm-c-api unit tests #4677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugong2019
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Add enhanced test coverage for wasm-c-api functionality: - Add wasm_extern_type testing with null input validation - Add wasm_memory internal API tests with WebAssembly module integration - Extend CMakeLists.txt to include new test files Signed-off-by: Gong, Pu <[email protected]>
pugong2019
force-pushed
the
pu/unit-enhance
branch
from
1be7026 to
328b14b
Compare
lum1n0us
added
the
ai-assistant
lum1n0us
reviewed
Oct 27, 2025
Collaborator
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
tests/unit/wasm-c-api/enhanced_gen_wasm_c_api_test.cc is better than tests/unit/wasm-c-api/enhanced_gen_wasm_memory_new_internal_test.cc.
| ASSERT_NE(nullptr, engine); | ||
| store = wasm_store_new(engine); | ||
| ASSERT_NE(nullptr, store); | ||
| runtime = std::make_unique<WAMRRuntimeRAII<512 * 1024>>(); |
Collaborator
There was a problem hiding this comment.
should not call both wasm_engine_new() and wasm_runtime_full_init()(via WAMRRuntimeRAII). In this case, WAMRRuntimeRAII should not be involved.
|
|
||
| // Cleanup | ||
| wasm_func_delete(func); | ||
| wasm_functype_delete(functype); |
Collaborator
There was a problem hiding this comment.
need to cleanup externtype.
The own in its declaration WASM_API_EXTERN own wasm_externtype_t* wasm_extern_type(const wasm_extern_t*); indicates an ownership transfer.
|
|
||
| // Cleanup | ||
| wasm_func_delete(func); | ||
| wasm_functype_delete(functype); |
Collaborator
There was a problem hiding this comment.
need to cleanup externtype.
The own in its declaration WASM_API_EXTERN own wasm_externtype_t* wasm_extern_type(const wasm_extern_t*); indicates an ownership transfer.
|
|
||
| // Cleanup | ||
| wasm_global_delete(global); | ||
| wasm_globaltype_delete(globaltype); |
Collaborator
There was a problem hiding this comment.
need to cleanup externtype.
The own in its declaration WASM_API_EXTERN own wasm_externtype_t* wasm_extern_type(const wasm_extern_t*); indicates an ownership transfer.
| // The fact that we can get exports means the instance was created | ||
| // successfully which means wasm_memory_new_internal was called and | ||
| // succeeded | ||
| ASSERT_GE(exports.size, 0u); |
| } | ||
|
|
||
| // Create multiple instances to exercise memory creation paths | ||
| for (int i = 0; i < 3; i++) { |
|
|
||
| // Test Case 12: Test error handling paths in memory creation | ||
| TEST_F(WasmMemoryNewInternalTest, | ||
| ErrorHandlingPaths_MemoryCreation_HandlesFailuresGracefully) |
Collaborator
There was a problem hiding this comment.
Similar to a previous one.
|
|
||
| // Test Case 13: Test comprehensive parameter validation | ||
| TEST_F(WasmMemoryNewInternalTest, | ||
| ParameterValidation_ComprehensiveTest_CoversAllPaths) |
Collaborator
There was a problem hiding this comment.
This case appears to be a simple combination of previous ones.
Collaborator
tests/unit/wasm-c-api/enhanced_gen_wasm_c_api_test.ccPASS: 11. NEED MODIFICATION: 1. DROP: 1.
tests/unit/wasm-c-api/enhanced_gen_wasm_memory_new_internal_test.ccPASS: 4. NEED MODIFICATION: 3. DROP: 6.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enhanced test coverage for wasm-c-api functionality: