Fix mismatch of enum sizes between WASM and host #4676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Kouba <[email protected]>
dkouba-atym
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
|
I believe we should synchronize this modification with core/iwasm/libraries/lib-socket/inc/wasi_socket_ext.h. |
lum1n0us
added
the
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with WAMR on Zephyr, I discovered that the sizes of a couple socket enums were not consistent between the host and inside of WASM. This resulted in an inability to create a UDP socket, as the layout of the enum was compressed (enums became 1 byte instead of 4) and the offset of
hints_enabledwas incorrect, and therefore all sockets created were TCP.In WASM:
sizes: enum=4, hints_t=12, off(type)=0 off(family)=4 off(en)=8In Zephyr host:
sizes: enum=1, hints_t=3, off(type)=0 off(family)=1 off(en)=2As a result I've enforced the struct sizes using the same method it was done for a different enum and added the appropriate assertions to validate.