Add support for metadata.code.call_targets section #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasdoe
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
yamt
reviewed
Nov 4, 2025
| struct WASMCompilationHint *next; | ||
| enum WASMCompilationHintType type; | ||
| uint32 offset; | ||
| bool used; |
There was a problem hiding this comment.
i feel it's simpler to have struct WASMCompilationHint common instead of duplicating individual fields.
| hint = hint->next; | ||
| } | ||
| if (hint != NULL) { | ||
| ((struct WASMCompilationHintBranchHint *)hint)->used = true; |
There was a problem hiding this comment.
no need to cast as the used field is in WASMCompilationHint as well.
| while (curr != NULL) { | ||
| if (!curr->used) { | ||
| printf("Unused hint for function %u, offset: %x\n", | ||
| i + module->import_count, curr->offset); |
There was a problem hiding this comment.
we usually don't use printf.
maybe LOG_WARNING?
| uint64_t | ||
| aot_func_name_hash(const char *name) | ||
| { | ||
| return MD5Hash(StringRef(name)); |
There was a problem hiding this comment.
is this function ubiquitously available?
i suspect it isn't.
| struct WASMCompilationHint *next; | ||
| enum WASMCompilationHintType type; | ||
| uint32 offset; | ||
| bool used; |
There was a problem hiding this comment.
is this used field only for diagnostic purposes?
| return true; | ||
| fail: | ||
| return false; | ||
| } |
There was a problem hiding this comment.
put a blank line between functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4460, I also implemented call targets hints in WAMR. Support in LLVM is tbd.
This also includes the generalization of our metadata parsing mechanism so that it'll be very easy to integrate new types of compilation metadata.
Basis: https://github.com/WebAssembly/compilation-hints/blob/main/proposals/compilation-hints/Overview.md